search

p-e-w / argos

Create GNOME Shell extensions in seconds
https://extensions.gnome.org/extension/1176/argos/
1.66k stars 112 forks source link

Support for GNOME 3.26 - 3.38, and GNOME 40 #127

Closed mwilck closed 2 years ago

mwilck commented 3 years ago

After waiting for a long time, I'm submitting my GNOME shell compatibility work for argos here. See #108 and #111.

real-or-random commented 3 years ago

I've been running this branch on 40 for a while and I can confirm it works fine.

dvogel commented 3 years ago

I've been using this branch with gnome-shell 3.36.7-0ubuntu0.20.04.1 for a few weeks and I haven't encountered any issues.

mwilck commented 3 years ago

@dvogel and @real-or-random, thanks for the feedback. Please note that I added the shellVersion patch on top just today, so if you could update to exactly this version I'd be grateful.

dvogel commented 3 years ago

@dvogel and @real-or-random, thanks for the feedback. Please note that I added the shellVersion patch on top just today, so if you could update to exactly this version I'd be grateful.

I had not noticed that. I just updated to this latest commit and restarted gnome-shell. No issues so far.

logix2 commented 3 years ago

I'm using this too with GNOME Shell 40.1 with no issues.

insign commented 3 years ago

Thank you so so so much

mwilck commented 3 years ago

@p-e-w, @insign, thanks a lot.

Anyone reading this, I could use help with these style fixes. As mentioned before, I'm really not an experienced Javascript programmer at all. I really just did what was necessary to make argos work again. I'll look into the requested changes/improvements, but they are quite many, and it'll take time. So if anyone has time to help out (ideally in the form of PRs against my master branch), I'd greatly appreciate it and we might be able to achieve a mainline merge more quickly.

insign commented 3 years ago

@mwilck @p-e-w using eslint we can check the styles before push.

mwilck commented 3 years ago

@insign, I believe you but my experience with this tool is exactly zero.

insign commented 3 years ago

@mwilck it's not you. @p-e-w needs to define a standard to we follow. PEW, can you do this?

p-e-w commented 3 years ago

The standard is "what the rest of the code looks like". I'm not going to write up formal requirements, sorry.

I don't understand what the problem is here. I'm asking that tabs be changed to spaces (which all of the existing code uses), single quotes be changed to double quotes (which all of the existing code uses), indentation matches the surrounding code, etc.. That has nothing to do with JavaScript per se. I'm not asking for any functional change, just that the style of the new code fits with the code that is already there so that the quality of the codebase doesn't degrade.

mwilck commented 3 years ago

Understood. I haven't said that it's a problem, just that I need to find time for making the changes.

marianrh commented 2 years ago

@p-e-w and @mwilck, thank you both for Argos and for creating this branch! I hope it can merged soon so we can enjoy Argos in Ubuntu 21.10 with GNOME 40 :)

RW21 commented 2 years ago

Great work! Hopefully it can be merged soon :+1:

RW21 commented 2 years ago

Is this PR still needing help regarding formatting/styling? I would recommend using eslint with eslint:recommended and let it fix everything. I could work on it in my free time.

mwilck commented 2 years ago

Is this PR still needing help regarding formatting/styling?

Yes, nothing has been done about that. I simply had no time.

I would recommend using eslint with eslint:recommended and let it fix everything. I could work on it in my free time.

That would be highly appreciated.

jefferyto commented 2 years ago

@mwilck Would you mind if I pull your commits into a new branch/PR and make the requested changes (or you can pull the changes into this branch/PR)?

jefferyto commented 2 years ago

@mwilck As requested in https://github.com/p-e-w/argos/pull/127#issuecomment-847717841, I have opened a PR for your master branch: https://github.com/mwilck/argos/pull/4

@p-e-w Would you mind reviewing the changes in https://github.com/mwilck/argos/pull/4 ? I will iterate the style fixes there :pray:

jefferyto commented 2 years ago

@p-e-w would appreciate it if you can take another look at this PR, I have addressed most (if not all) of your style concerns :pray:

kinduff commented 2 years ago

@p-e-w Would love to see this merged, either by you, or adding @mwilck as a maintainer for the great support it has provided. I'm sure I'm not the only one willing to donate in order to get 40-41 supported.

p-e-w commented 2 years ago

MERGED!!!

I would like to thank @mwilck, @jefferyto, @michel-slm, and @rammie for their combined effort to finally bring Argos into GNOME's present. While I don't use Argos myself anymore, it feels great to see that others care about the project enough to invest time to keep it working.