search

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)
http://finalterm.org
GNU General Public License v3.0
3.84k stars 179 forks source link

Support NixOS/Nixpkgs #269

Closed cstrahan closed 10 years ago

cstrahan commented 10 years ago

This issue is just to track the support that I'm adding to NixOS/Nixpkgs, and any questions that might come up along the way. I've already submitted PRs for libmx and keybinder-3.0. Once those two are accepted, I'll submit another for Final Term.

p-e-w commented 10 years ago

Interesting! I'm looking forward to see what will come of this. And thanks for introducing me to NixOS, never heard of it before :)

cstrahan commented 10 years ago

@p-e-w

Now that I have libmx and keybinder-3.0 in Nixpkgs, I've taken a stab at getting finalterm packaged too. It's pretty close, as you can see here: https://github.com/NixOS/nixpkgs/pull/3263

There are two remaining problems:

  1. The shell never appears (just a blinking caret)
  2. Typing into finalterm results in these debug messages:
(.finalterm-wrapped:5362): GLib-CRITICAL **: g_io_channel_write_chars: assertion 'channel->is_writeable' failed

I'm not sure how to debug this further; could you give me a suggestion or two on how to troubleshoot this (or perhaps provide you with logs)?

cstrahan commented 10 years ago

@p-e-w Good news! I have finalterm working. The problem was a reference in data/org.gnome.finalterm.gschema.xml to /bin/bash, which is a path that doesn't exist on NixOS. I'll see if I can get someone to review and accept https://github.com/NixOS/nixpkgs/pull/3263 shortly.

Given that Nix is a cross-platform package manager, adding support for non-Linux hosts should be pretty straight forward (just need to make sure that all of the dependencies build on the other platforms). Being a big Mac user, OS X will probably be the next platform that I'll try to add support for.

Globegitter commented 10 years ago

Wow, I haven't heard of NixOS before, that is some really great stuff. Thank you for introducing us to that @cstrahan and thank you for all the effort to make this possible.

Globegitter commented 10 years ago

@cstrahan I have just seen that https://github.com/NixOS/nixpkgs/pull/3263 got merged. Does this mean this can be closed now and I could get this to work on my Mac as well as give NixOS a try?

cstrahan commented 10 years ago

@Globegitter Yep!

If you want to install finalterm from Nixpkgs, first install the nix package manager:

bash <(curl https://nixos.org/nix/install)

You can then use the one-click installer here: http://hydra.nixos.org/build/12558343

Or, if you want to be a neckbeard about it, grab the latest nixpkgs repo and install finalterm like so:

git clone https://github.com/NixOS/nixpkgs.git
cd nixpkgs
nix-env -f . -i -A finalterm

Cheers!

p-e-w commented 10 years ago

Has anyone tested this on Mac? Does this mean that https://github.com/p-e-w/finalterm/issues/92 is fixed?

cstrahan commented 10 years ago

@p-e-w Presently, the Xorg/X11 packages don't build on Mac, which of course holds back a couple prerequisites packages. I have an open PR that brings proper Xorg support to darwin, which I hope will get merged soon: https://github.com/NixOS/nixpkgs/pull/3101. Once that is merged, I'll see if I can get the other dependencies building on Darwin (which should be fairly trivial).

If you'd like, you can assign #92 to me, or perhaps create a Nix-specific issue and assign that. Either way, I'll make sure to keep everyone updated on my status.

(As an aside, a nice effect of all of this is that the package definition can also be used as a development environment on both Mac and Linux. Going from a pristine machine to a working development environment will be as easy as "nix-shell -p finalterm".)

buschjost commented 10 years ago

@cstrahan I just saw that your open PR got merged. It would be really cool if you could get this to work on Mac as well.

Globegitter commented 10 years ago

@cstrahan Just tried it out on my Mac with the latest official release. I know this is going a little bit off-topic, but do I need the latest version straight from github to get anything to work? It tells me finalterm not found. Also I assume it is not quite ready for the Mac or is it? And my last question which you might not be able to answer and is completely off-topic anyway but are nix packages supposed to work with Fish? Seems I am getting an error when running the nix.sh Thanks for all the work you have done here btw.

Globegitter commented 9 years ago

@cstrahan Just tried again on my Mac and I am getting the following error: screen shot 2014-10-19 at 14 52 02

If I set allowBroken to true it starts to install but throws errors towards the end. I can post the error-messages if it helps any.

nashley commented 9 years ago

Error output would be helpful. If you can post them as text instead of an image, that would be even better.

On October 19, 2014 10:22:45 AM EDT, Markus Padourek notifications@github.com wrote:

@cstrahan Just tried again on my Mac and I am getting the following error: screen shot 2014-10-19 at 14 52 02

If I set allowBroken to true it starts to install but throws errors towards the end. I can post the error-messages if it helps any.

Reply to this email directly or view it on GitHub: https://github.com/p-e-w/finalterm/issues/269#issuecomment-59651273

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Globegitter commented 9 years ago

This is the whole build output in a gist: https://gist.github.com/Globegitter/3a5bf3ccd3ad8ed213c5

cstrahan commented 9 years ago

@Globegitter I've added this to my personal Trello board. I'll see if I can look into it over the next couple days.

Globegitter commented 9 years ago

@cstrahan Awesome, thanks you!

Globegitter commented 9 years ago

@cstrahan Had any time yet to look into that by an chance?