search

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)
http://finalterm.org
GNU General Public License v3.0
3.84k stars 179 forks source link

Set always on top on drop down #291

Closed mola closed 10 years ago

p-e-w commented 10 years ago

Thank you for your effort. This PR is exactly along the lines that I was hoping for to solve the Guake mode problems.

Unfortunately, it does not work, at least not on my system (Fedora 20, GNOME 3.10). The window is not reliably on top, and still shows the "Final Term is ready" notification.

To reproduce, I do the following:

  1. Start Final Term
  2. Press the "TOGGLE_DROPDOWN" hotkey (F10 in my case)
  3. Final Term drops down, but does not stay on top
  4. If I now press the hotkey twice more (hiding and showing the window) Final Term does stay on top
  5. When another window is focused and I press the hotkey, Final Term shows up, but is usually not focused, and triggers a "Final Term is ready" notification

In Guake, which I have running on the same system, all this works flawlessly.

It would be fantastic if these issues could be addressed and we could finally get proper dropdown functionality!

mola commented 10 years ago

hi, i have fedora 20 and gnome 3.12 (gtk 3.12) and no problem,

  1. Start Final Term
  2. Press the "TOGGLE_DROPDOWN" hotkey (F10 in my case)
  3. Final Term drops down and stay on top ;)
p-e-w commented 10 years ago

I just did a clean install of Fedora 20 in a VM, then cloned your repo directly, built and installed Final Term, and executed the steps described above.

Both problems persisted as described :( I really want this to work, but I just can't get it to. Note that in my trials, I pressed the hotkey directly after Final Term started, without hiding it beforehand.

p-e-w commented 10 years ago

Merged, as I found fixes for both issues:

  1. set_keep_above should be called after show
  2. present should be used instead of show

The behavior of the dropdown is now almost perfect, except for the fact that it still sometimes fails to focus the window (though much more rarely than before); I'm tracking this in https://github.com/p-e-w/finalterm/issues/295.

Thank you again for your contribution! I have added your name to the About dialog credits.