search

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)
http://finalterm.org
GNU General Public License v3.0
3.84k stars 179 forks source link

Avoid a process spawn in trim function #360

Closed lwandrebeck closed 9 years ago

lwandrebeck commented 9 years ago

no more call of sed, use of bash internals.

p-e-w commented 9 years ago

It seems that this idea was also part of https://github.com/p-e-w/finalterm/pull/357, which I just merged.

lwandrebeck commented 9 years ago

Hello pew ! Trim function wasn't changed in #357. Best, Laurent. Le 23 sept. 2014 19:01, "Philipp Emanuel Weidmann" notifications@github.com a écrit :

It seems that this idea was also part of #357 https://github.com/p-e-w/finalterm/pull/357, which I just merged.

— Reply to this email directly or view it on GitHub https://github.com/p-e-w/finalterm/pull/360#issuecomment-56553500.

p-e-w commented 9 years ago

Yes it was: https://github.com/p-e-w/finalterm/pull/357/files#diff-adf4e100fdd82beec1acac666e9db93cL61.

lwandrebeck commented 9 years ago

Doh sorry missed it. Cheers, Laurent. Le 23 sept. 2014 19:10, "Philipp Emanuel Weidmann" notifications@github.com a écrit :

Yes it was: https://github.com/p-e-w/finalterm/pull/357/files#diff-adf4e100fdd82beec1acac666e9db93cL61 .

— Reply to this email directly or view it on GitHub https://github.com/p-e-w/finalterm/pull/360#issuecomment-56554835.