Fixed a segfault when waitpid returned 0, should fix the url crash

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)

http://finalterm.org

GNU General Public License v3.0

3.84k stars 179 forks source link

Fixed a segfault when waitpid returned 0, should fix the url crash #363

Closed gmittert closed 9 years ago

gmittert commented 9 years ago

Fixed the segfault that occured here: https://github.com/p-e-w/finalterm/issues/215, though it might actually be an issue about mixing the glib api for processes and manually handling them.

When launch_default_for_uri is called, it sends SIGCHLD, which triggers the signal handler on a process that it cannot find.

p-e-w commented 9 years ago

At last I was able to reproduce the issue on my system, and confirm that your PR fixes it.

Merged! Thank you for your contribution. I have added your name to the about dialog credits.