Issue #377 collapse button staying red

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)

http://finalterm.org

GNU General Public License v3.0

3.84k stars 179 forks source link

Issue #377 collapse button staying red #382

Closed Eugene-msc closed 9 years ago

Eugene-msc commented 9 years ago

Basically it checks if the current command is not empty. If it's not then the command was actually executed, otherwise last_command is discarded

p-e-w commented 9 years ago

This looks good now, but I actually just found that we shouldn't even have this problem in the first place as the "preexec" script apparently has functionality to detect empty commands. For some reason, this is not working though (which is the real bug); I'm currently investigating why.

p-e-w commented 9 years ago

I found the issue underlying the bug and fixed it in https://github.com/p-e-w/finalterm/commit/39b078b2a96a5c3c9e74f92b1929f383d220ca8b (explanation in https://github.com/p-e-w/finalterm/issues/377#issuecomment-63171648). I'm closing this PR since it only masks the real problem which is now solved.