search

p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)
http://finalterm.org
GNU General Public License v3.0
3.84k stars 179 forks source link

Fix #377 #384

Closed arkocal closed 9 years ago

arkocal commented 9 years ago

This is not a very beautiful solution, but reading the output line seems to be the only solution, because return value is not set to 0 when an empty command is run.

p-e-w commented 9 years ago

Have you seen @Eugene-msc's PR for the same issue here?

arkocal commented 9 years ago

That is a much cleaner solution indeed :+1: . I forgot about get_commad. I am keeping this branch on my local anyway, in case we need to run this check for any other line than the last one.

Btw. this was why I asked whether you are assigning the issues :smile: .

p-e-w commented 9 years ago

Note that GitHub allows me to assign issues only to myself or to members of the "organization" (which we don't have), so this feature doesn't help us. IMO, the best way to avoid duplicate work is to drop a quick "I'm working on this" comment on the relevant issue thread.

p-e-w commented 9 years ago

I found the issue underlying the bug and fixed it in https://github.com/p-e-w/finalterm/commit/39b078b2a96a5c3c9e74f92b1929f383d220ca8b (explanation in https://github.com/p-e-w/finalterm/issues/377#issuecomment-63171648). I'm closing this PR since it only masks the real problem which is now solved.