p-e-w / finalterm

At last – a modern terminal emulator (NO LONGER MAINTAINED)
http://finalterm.org
GNU General Public License v3.0
3.84k stars 179 forks source link

compilation error #411

Closed hoenirvili closed 7 years ago

hoenirvili commented 9 years ago
/tmp/yaourt-tmp-hoenir/aur-finalterm-git/src/finalterm-git/src/TerminalView.vala:229.44-229.48: error: direction of parameter `x' is incompatible with the target delegate
            text_menu.menu.popup(null, null, (menu, out x, out y, out push_in) => {
                                                    ^^^^^
/tmp/yaourt-tmp-hoenir/aur-finalterm-git/src/finalterm-git/src/TerminalView.vala:229.51-229.55: error: direction of parameter `y' is incompatible with the target delegate
            text_menu.menu.popup(null, null, (menu, out x, out y, out push_in) => {
CJD14 commented 9 years ago

check this fix from issue #408 https://github.com/joshslark/finalterm/commit/04697ea8632feb691238000c856f89f60cc0a612

I had the same issue, must have been an update in vala's source dropping the use of out x, out y in that manner. I cant say for sure. What I can say is I was able to successfully build doing the following as stated in the above links.

simply vim src/TerminalView.vala and change line 229 to this:

text_menu.menu.popup(null, null, (menu, ref x, ref y, out push_in) => {

instead of this:

 text_menu.menu.popup(null, null, (menu, out x, out y, out push_in) => {

just change the out x, out y, not the out push_in, to ref x, ref y, out push_in

hoenirvili commented 9 years ago

Good day sir, i will try this right now , thanks for the tip:D

hoenirvili commented 9 years ago

Worked like a charm thanks for everything ! Have a good day sir !

[Update] Now after instaling it gives me

~ $ : finalterm

(finalterm:756): GLib-GObject-WARNING **: value "0" of type 'gint' is invalid or out of range for property 'window-scaling-factor' of type 'gint'

(finalterm:756): Clutter-CRITICAL **: The Clutter backend is not a X11 backend

(finalterm:756): Clutter-CRITICAL **: The Clutter backend is not a X11 backend
Segmentation fault (core dumped)
CJD14 commented 9 years ago

I got that too. Which I reported as issue #410 I was assisted to fix it temporarily by using

export CLUTTER_BACKEND=x11
finalterm

but that doesnt fix the root issue so expect instability. still early in development, and Gnome 3.16 changed all kinds of things, which in turn broke this sadly.

hoenirvili commented 9 years ago

Thanks for all, now it's working btw i'm on arch xfce4 not gnome

epitron commented 9 years ago

Nice!

This needs to be merged.