search

p-e-w / ternimal

Simulate a lifeform in the terminal
GNU General Public License v3.0
1.06k stars 31 forks source link

Cargo #3

Closed jklmnn closed 6 years ago

jklmnn commented 6 years ago

While you've stated that it doesn't depend on cargo you could still provide it. This would make it probably easier for new users to access this project. Beside that providing cargo doesn't make the project depend on it, you could still build the project with plain rustc. @xTibor already added a cargo build in his repository (https://github.com/xTibor/ternimal/commit/47c36116258385835dc88153046367c9bdbf103e).

xTibor commented 6 years ago

I agree, it would be handy to have Cargo support. However my reason for cargolizing the project on that branch was to be able to cross-compile it with Xargo for Redox.

p-e-w commented 6 years ago

Perhaps I'm missing something – what exactly would be the benefit here?

There are no dependencies to fetch, nothing to incrementally compile (as there is only one source file), no tests to run... AFAICT the only difference would be that you compile with cargo build --release instead of rustc -O ternimal.rs.

That being said, running this on Redox sounds exciting. Please post screenshots if you get it to work!

jklmnn commented 6 years ago

Beside making the entry for new users easier (most people I think are used to cargo build/run/install) it also makes porting easier (as @xTibor said) and it would open the possibility (if uploaded to crates.io) to install it directly via cargo. Also it would prevent that people need to add cargo each time they need it on their own.

Apart from that I've read your README and I'm totally Ok with it if you say no just because you don't want to have cargo ;)

robinst commented 6 years ago

Another reason for using cargo is that you can use IDE things such as IntelliJ Rust or VS Code with the RLS plugin for editing the project and you get error reporting and code analysis and all those things.

(Also, having a Cargo.toml doesn't prevent you from still running rustc -O ternimal.rs if you want.)

p-e-w commented 6 years ago

Based on the information in this issue, I have decided not to add Cargo support at this time.

I like the minimal repository layout too much and I just don't feel the advantages of Cargo outweigh that for me.

robinst commented 6 years ago

There's a fork with cargo added here: https://github.com/xTibor/ternimal-cargo

With that, installation is really simple, just run cargo install --git https://github.com/xTibor/ternimal-cargo