p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

Error in NU HTML Checker Due to Incorrect use of 'allowfullscreen' Attribute #14

Closed naumch1k closed 6 months ago

naumch1k commented 8 months ago

Issue Description

Background:

NU HTML Checker throws an error due to the allowfullscreen attribute being set to true on the <iframe> element within the embedded Google Maps code.

Screenshot 2024-02-01 at 8 31 49 PM

Proposed Solution:

To address the issue, eliminate the ="true" segment from the attribute, retaining only allowfullscreen within the iframe element. This adjustment ensures compliance with HTML standards and resolves the error flagged by NU HTML Checker.

An example of the correct usage of the allowfullscreen attribute:

<iframe class="map__iframe" src="" allowfullscreen loading="lazy" referrerpolicy="no-referrer-when-downgrade"></iframe>

Quick Instruction for Working on the Issue

‼️ Before checking out to a new branch, ensure you have the latest updates from the main by running git pull command.

This pull request resolves [#123](https://github.com/username/repository/issues/123)
wwily commented 6 months ago

.take

github-actions[bot] commented 6 months ago

@wwily 👋 Thanks for showing interest in this issue ❤️ This ticket seems to be in good hands with another contributor.