p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

Create variable for --common-transition #27

Closed Woolfs1423 closed 6 months ago

Woolfs1423 commented 7 months ago

Issue Description

Background:

In our project, there is a transition property that repeats multiple times. Instead of writing the same value a lot of times, I suggest creating a CSS variable and replacing every transition in the project with it.

Proposed Solution:

Create a CSS variable called --common-transition and use it in every CSS file where we need a transition.

Quick Instruction for Working on the Issue

‼️ Before checking out to a new branch, ensure you have the latest updates from the main by running git pull command.

naumch1k commented 7 months ago

@Woolfs1423 You did an outstanding job describing this issue 🔥🔥🔥

I do have a single suggestion to add: since we have multiple pages, we should check if any elements on components.html use transitions. If they do, we should also recommend importing our root.css into pages/components.css and replacing all transition occurrences with a newly created CSS variable for those elements on components.html 😊

Woolfs1423 commented 7 months ago

@naumch1k , thank you for pointing that out, and I've added it to the description.

MarPostovik commented 6 months ago

@Woolfs1423 Since we now also have a page form.html, I think you should also recommend importing root.css into pages/form.css

naumch1k commented 6 months ago

@MarPostovik @Woolfs1423 Should we just say that root.css needs to be imported on all pages? We'll soon add more variables, like colors, common paddings, typography, etc., which will be used on every page..

Woolfs1423 commented 6 months ago

@naumch1k Can you please tell me if that's clear? After creating the file, the path to it should be written to all the pages in the pages folder.

MarPostovik commented 6 months ago

@Woolfs1423 I think it's better to formulate it like this:

After creating the file root.css, make sure that it is imported into all pages of our project in the corresponding files which are placed in the folder pages.

But let's wait for the response of Irina. @naumch1k What do you think about it?

naumch1k commented 6 months ago

@MarPostovik Love it ❤️

wwily commented 6 months ago

.take

github-actions[bot] commented 6 months ago

@wwily 👋 Thanks for picking up this issue! 🙌 Feel free to reach out if you need any help or have questions!