search

p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

Bug: change accessibility tags to Russian language #45

Closed wwily closed 5 months ago

wwily commented 6 months ago

Describe the bug Our project Pink is in Russian language. This implies that all content in it should be in Russian, including attributes for accessibility and title. Our pages index.html and components.html have their language set to English within the HTML tag. You can learn more about the tag here.

<html lang="en">

Also the title of our index.html is "Pink App". We ought to interpret it into "Приложение Pink". We can leave the word "Pink" in English because it is the proper name. At that point we got to ensure that all of the words "Pink" in our project are in English. (At least the title of page form.html has the word "Пинк", but it may be more, go through all HTML files and check if all texts are in Russian). Hint: take a look at the section reviews and its aria-labels.

To summarize, we have:

To Reproduce Steps to reproduce the behavior:

  1. Go to index.html, components.html
  2. Look at the lang tag and attributes for accessibility.
  3. See that some text in the attributes for accessibility are written in English. We can also see that the attribute lang in tag <html> does not have the appropriate value.

Expected behavior When the bug is fixed, the lang tag will be changed in index.html and components.html. All accessibility attributes are in Russian, while leaving the name "Pink" in English.

Desktop:

Quick Instruction for Working on the Issue ‼️ Before checking out to a new branch, ensure you have the latest updates from the main by running git pull command.

image

This pull request resolves [#issue_number](link_to_the_issue). Replace issue_number with the actual issue number and link_to_the_issue with the link to the respective issue. For example:

This pull request resolves [#123](https://github.com/username/repository/issues/123)
github-actions[bot] commented 6 months ago

@wwily 👋

Thanks for dropping in with the issue! Our team is ready to dive into it as soon as possible! 🚀

If you would like to work on this issue, please wait for us to decide if it's ready; hang tight until we've given it the green light. The issue will be ready to work on once we remove the Needs triage label.

To claim an issue that does not have the Needs triage label, please leave a comment that says ".take". If you have any questions, please follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

Let's make some magic together! ✨

MarPostovik commented 6 months ago

Hi @wwily . Good job on writing issue! I have a few suggestions to improve it:

wwily commented 6 months ago

Fixed)

NazarPauk commented 5 months ago

.take

github-actions[bot] commented 5 months ago

@NazarPauk 👋 Thanks for picking up this issue! 🙌 Feel free to reach out if you need any help or have questions!