p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

Feature modal window #49

Open wwily opened 5 months ago

wwily commented 5 months ago

Description

The modal window is used on the form page. It allows you to understand whether the operation was successful or not. To see the window, you need to open developer tools and add the class popup_active to the popup. Also It has two modifiers _for_success-event and _for_failure-event. They are used for the popup__paragraph and popup__footer classes. Here is how you can use them:

Task Link

Link to Figma

Changes Made

I created a modal window.

Checklist

Before submitting this pull request, please ensure the following:

MarPostovik commented 5 months ago

Hey, @wwily could you please provide the code example of the usage of modifiers in the description of pull request? Also, could you kindly add screenshots of the modal both of success and failure types?

MarPostovik commented 5 months ago

@wwily you should also indicate that in order to see the modal you need to add the class popup_active. Write this in the description of the PR and in the file components.html.

MarPostovik commented 5 months ago

@wwily You didn't import the file popup.css. Please do this. When you do this, you will see that the modal covers other components on the page. So let's not add the class popup_active. Let's just indicate in the description of the component that in order to see the modal the person will need to open developer tools and add the class popup_active to the popup.

MarPostovik commented 5 months ago

Hey @wwily , we should import popup.css before popup_active.css because otherwise it covers styles of the file popup_active.css and if we use the classes properly, we will never see the modal.

We should use the classes like that: By default there is only the class popupand we don't see the modal.

<div class="popup">
 ...
</div>

If we add class popup_active, then there are two classes (popup and popup_active) and we see the modal.

<div class="popup popup_active">
 ...
</div>

Please let me know if you understand this and indicate in the description of PR and in the description of component that in order to see the modal the person will need to go to the developer tools and add class popup_active to the popup.

wwily commented 5 months ago

hey! yes, I got it. Thank you for the suggestion:)

MarPostovik commented 5 months ago

@wwily That's great! Please update also the description of the component in the file components.html with this line, as you've already done in the description of the PR:

To see the window, you need to open developer tools and add the class popup_active to the popup.

wwily commented 5 months ago

done 🙂