p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

refactor: corrects the writing of media requests #53

Closed wwily closed 6 months ago

wwily commented 6 months ago

Description

This pull request resolves #40

Changes Made

I ensured uniform usage and formatting of media queries throughout the project.

From this:

@media (max-width:1199px){
...
}

@media (max-width:659px){
...
}

To this:

@media screen and (max-width: 1199px){
...
}

@media screen and (max-width: 659px){
...
}
naumch1k commented 6 months ago

Hey, @NazarPauk @MarPostovik 👋 Do you guys have any formatting rules for media requests? Most of them have a space between max-width: and the value, but the ones in this PR don't.

@media screen and (max-width: 659px) {}
/* vs */
@media screen and (max-width:659px) {}
MarPostovik commented 6 months ago

@naumch1k Thank you for noticing this. I think we should stick to the first option (with the space). @wwily Would you kindly add the spaces to the media queries that don't have them?

wwily commented 6 months ago

I made changes:)