search

p-hennessy / Bolt

All the parts for building a Discord robot
https://docs.bolt.bot/
MIT License
8 stars 6 forks source link

[core.Plugin] Command / plugin race condition #41

Closed p-hennessy closed 8 years ago

p-hennessy commented 8 years ago

I will need to test this; but I had a thought today

What if someone unloads a plugin whist a command within that plugin is performing an action.

I'm inclined to think it would be fine because the command system holds on to the method which is bound to an instance. Plugin unloading just unregistered the commands and gets rid of the reference to the instance.

p-hennessy commented 8 years ago

Fixed in : 1d1e2c93f93086fd4638a786d090e9f3a636e7c3