p-kuen / PatchProtect

A Prop Protection for Garry's Mod
12 stars 10 forks source link

prop in prop protection dont work anymore. #120

Open theaoneone opened 8 years ago

theaoneone commented 8 years ago

prop spam protection dont work anymore, user can still spam props.

theaoneone commented 8 years ago

add more info. the spam menu there is a cleanup option that i can select it doesn't work anymore. and can you add one more thing like make it not delete but just transparent.

d-kuen commented 8 years ago

Hi,

prop spam protection dont work anymore, user can still spam props

Seems, that october-update patched PatchProtect to death. Any client/server-console-output?

the spam menu there is a cleanup option that i can select it doesn't work anymore

same as above

can you add one more thing like make it not delete but just transparent Which advantages should it have to do that?

The spammed props would still produce lags. It's not the texture, which produces the lag. People would run against those transparent props and would wonder what it is. I don't think, this is a good idea. sry

theaoneone commented 8 years ago

Prop spawn inside a prop will crash all servers. If there is a way that you can make it not delete but first make it transparent and the after 5 more prop it will deleted.

theaoneone commented 8 years ago

Update the prop protection is working for some reason. But I have to restart the server to make it work.

theaoneone commented 8 years ago

For me and all my staff. I think making it transparent is the best. So people have to physgun it to make it not transparent so it won't lage the server when someone spawning prop a lot but with good intentions.

d-kuen commented 8 years ago

Update the prop protection is working for some reason. But I have to restart the server to make it work.

On the gmod-update-notes they say that a restart is required, so you had to do it anyway.

For me and all my staff. I think making it transparent is the best. So people have to physgun it to make it not transparent so it won't lage the server when someone spawning prop a lot but with good intentions.

ah now i know what you mean. You talk about the fpp spam-protection.

It's not the transparency, which would stop the lag. The props also gets freezed, which will then deactivate some phsyics on the freezed prop.

also people could then spawn 5 props, physgun them all and then you have server-lag again. If you repeat that multiple times on a hidden place, this would be probably not that effective.

if you want to let people spawn a lot, but not inside another prop, just reduce the cooldown-time and keep prop-in-prop protection enabled.

theaoneone commented 8 years ago

anyway that you can use a config file to set different ranks that prop protection look it as a admin. Like moderator.

d-kuen commented 8 years ago

Set moderator as an ingame-admin, as many admin-mods support and you have the same effect :) The reason for this is, that PatchProtect uses the native ranking-system and doesn't define it's own.

theaoneone commented 8 years ago

Domii the propinprop protection you have is not working. I can easily crash the server with like 5 props.

d-kuen commented 8 years ago

Ok, so it seems that there is some work required.

I know that I used an ingame-function to check if there is a prop-in-prop.

There can be two problems at the moment:

  1. the prop(s) you are trying out is not catchable by the function
  2. the whole function doesn't work anymore

Number 1 is not that easy to solve because any prop-in-prop check can miss in some scenarios. It is possible to make them safer, but they will require a lot of cpu load on each prop-spawn, which doesn't fit in the pattern of PatchProtect.

Number 2 is also not that easy, because it can result in a lot of work. Most prop-protections draw a trace through an edge of the bottom to the opposite on top and then check if the trace goes through something. It's a good and fast solution, but doesn't catch everything. This would work on cubes, but not quite well on that water-storage. (tested that earlier)

The ingame-function worked quite well but didn't check it since multiple gmod-updates.

Sadly, I am quite busy right now and cannot say, when/how much I am able to code a new prop-in-prop protection. I don't want to copy a prop-in-prop protection from other pp's because that sometimes results in more work as implementing them by self.

I cannot guarantee anything, but we will see.

Maybe you or somebody would have a look at the code to search for issues or something like that. (It is also not that difficult to read/understand)

EDIT: https://github.com/Patcher56/PatchProtect/blob/9b83f274fd2ded9f5f7eef6d1f9334c3b4a092ca/lua/patchprotect/server/propprotection.lua#L74 -> location of prop-in-prop protection

We could then merge the request and done. That's the huge advantage of github. :P

theaoneone commented 8 years ago

i only have friend who can do like only anti cheat patches. I am just going to wait for you to work on it. FPP takes too much cpu.

theaoneone commented 8 years ago

One more thing can you add a clean up option for dropped weapons.