p-lr / MapView

A Fast, memory efficient Android library to display tiled maps, with support for markers, paths, and rotation.
Apache License 2.0
184 stars 38 forks source link

Best performance for many markers #48

Open az-faro opened 4 months ago

az-faro commented 4 months ago

Say that you have a map with thousands of markers, are there any best practices for how to handle that to still have good performance?

p-lr commented 4 months ago

~This library supports markers lazy loading, which does what you describe. You can see an example in the demo app (see "Markers lazy loading").~

EDIT: sorry I thought the issue was about MapCompose. MapView indeed does not support markers lazy loading, and is on maintenance mode. So you're right, you would have to manually set markers visibility.

az-faro commented 4 months ago

Thanks for the info, I might look into MapCompose then.

As for MapView, would you say adding and removing the entire markers is better or worse from a performance perspective vs just hiding the markers that shouldn't be shown?

p-lr commented 4 months ago

I would only set the visibility of markers to GONE or VISIBLE because adding and removing the markers causes the parent layout to recalculate its size.

devjta commented 4 months ago

I would also need performance and/or clustering in the old one.. We dont want to use compose, as we had really bad experience. Our customers are still using crappy devices and everything was just slow, so we needed to redo everything in XML again..

Just so you know, what I am talking about: We are talking about something like >10k points on a single screen. The map is not infinite (its a plan of a building).

The original https://github.com/moagrius/TileView could handle that better.. But it had issues with recycling bitmaps and crashing the app then -.-

az-faro commented 4 months ago

@devjta What I do when there is a lot of markers on the screen at once is that I start randomly hide them. If you have > 10k markers as you say then no one could possibly see anything useful with all of them visible anyway, so it's better to start hiding stuff randomly to reduce the clutter (it will still just look like a mess of markers to the user, but from a performance perspective it should be a lot better). Then as the user zooms in, less items will be on the screen at once and you can let more markers be visible.

The other option obviously being to cluster several nearby items together in a single marker (but again as this isn't supported natively by the library you would have to roll your own solution).

devjta commented 4 months ago

@az-faro yeah, we kinda need some z-index logic and hide the pins which are mostly behind.. sounds like a good idea.

And yeah, I would need to add the clustering in there. If I get it to run successfully, I would even upload it. We already customized many things in the library, so we basically forked it already.