search

p-lr / TrekMe

Offline maps Android application, for trekking, biking, etc.
GNU General Public License v3.0
106 stars 30 forks source link

Refactor kotlin #94

Closed theycome closed 12 months ago

theycome commented 12 months ago

Refactoring the contents of core.map.data package.

Mostly getting rid of explicit null comparisons and try catch blocks.

p-lr commented 12 months ago

Your PR has a lot of changes and I would be more confident merging smaller PRs. For example, one or two PRs for the files under the dao package, another one for the mappers, etc. That would also simplify testing, to ensure there's no regressions.

theycome commented 12 months ago

Ah, well, makes sense, will downscale,