search

p-m-p / node-fitbit

Fitbit API client for Node.js with shared data models
36 stars 16 forks source link

adding devices support #2

Closed obihann closed 10 years ago

p-m-p commented 11 years ago

Does this work? The resource url will be wrong (it will contain the date section) as I've only added support for the collection resources as yet. I plan to add the user resource soon which will also require changes to the helper method that returns the resource endpoints.

I don't particularly like the device method you added that takes an index, it would be much nicer to fetch the device by it's device version with methods like one, aria or flex.

obihann commented 11 years ago

It does currently work, I really just added it because I'm building a fitbit / node app that will send push notifications to a user when they have been inactive for a set period of time… Basically a tool to get me away from my cubical every hour and stretch my legs..

I like the idea of fetching by device name though, I can make this change and submit a new pull request if you like. That wouldn't be a problem at all.

On 2013-08-18, at 10:52 AM, Phil Parsons notifications@github.com wrote:

Does this work? The resource url will be wrong (it will contain the date section) as I've only added support for the collection resources as yet. I plan to add the user resource soon which will also require changes to the helper method that returns the resource endpoints.

I don't particularly like the device method you added that takes an index, it would be much nicer to fetch the device by it's device version with methods like one, aria or flex.

— Reply to this email directly or view it on GitHub.

p-m-p commented 11 years ago

Sounds cool. If you want to add the methods then great, I'll pull it in and fix the resource URL.

obihann commented 11 years ago

OK We now check by the deviceVersion object, which contains the device name "flex", "one", etc. Let me know what you think.

p-m-p commented 11 years ago

Great, thanks, I'll pull this in soon as I get a chance and fix the helper methods to set the correct endpoint.

p-m-p commented 10 years ago

Moved over to #4 so closing this one.