search

p-m-p / node-fitbit

Fitbit API client for Node.js with shared data models
36 stars 16 forks source link

Please make this one change! #3

Closed logicware closed 10 years ago

logicware commented 10 years ago

Please change the following line in the /lib/fitbit.js:

var OAuth = require('OAuth')

to

var OAuth = require('oauth')

It works fine on Windows but on Unix/Linux based systems it causes an error. I changed this line and now my app is running fine on my AWS EC2 instance.

Regards

Matloob

p-m-p commented 10 years ago

Hmmm, build is fine on Linux for me. Also see https://github.com/p-m-p/node-oauth/blob/master/lib/oauth.js#L9

p-m-p commented 10 years ago

Ignore my last comment! I'm mocking the lib out in my tests.

I'll update it when I get a chance, thanks.

simon-bond commented 10 years ago

+1.

p-m-p commented 10 years ago

I've actually updated the code if you want to just reference the repo in your package.json. I'll push a new version soon as I get a chance to make some other changes I have outstanding.

logicware commented 10 years ago

Thanks. I have switched to another lib, anyway.