search

p-m-p / node-fitbit

Fitbit API client for Node.js with shared data models
36 stars 16 forks source link

Adding "extraParams to getRequestToken call #9

Closed hallta closed 8 years ago

hallta commented 9 years ago

Updated getRequestToken in the client to match the interface in oauth's getOAuthRequestToken, so to pass extra arguments when needed.

p-m-p commented 9 years ago

Hey, thanks for this. I'll add it in when I get a chance but will probably have to switch the additional parameters to be the second parameter to prevent breaking the current API.

p-m-p commented 9 years ago

Actually I'll do as you have but check the type and switch them internally. Thanks!

hallta commented 9 years ago

Oh wow, yeah, I totally missed that. Thanks!

On Thu, Mar 12, 2015 at 3:34 AM, Phil Parsons notifications@github.com wrote:

Actually I'll do as you have but check the type and switch them internally. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/p-m-p/node-fitbit/pull/9#issuecomment-78456286.