Added support for version 0 (zero)

p-meier / hapi-api-version

An API versioning plugin for hapi.

Apache License 2.0

74 stars 26 forks source link

Closed ruionwriting closed 7 years ago

p-meier commented 8 years ago

Hi. Thanks for your PR. I have two questions...

Why should the plugin support version zero? Don't you normally start with version 1?
Why did you turn off lab-code-coverage on some lines?

I'm currently on a workshop for the next 10 days and won't have internet access. So my next reply may take a while...

ruionwriting commented 8 years ago

@p-meier. Thanks for your comments.

Version zero because is a good practice to exercise version compatibility transitions during pilot stage for public APIs. Let's say v0 is alpha/beta and we launch 1 as release candidate and we allow also the pilot consumers to exercise their side actions/code changes during the initial test phase.
I was expecting this comment about coverage. Tbh i could get any logic reason to lab to complain about it. May I need some help here.

ruionwriting commented 7 years ago

@p-meier any change that you'll accept this change?

p-meier commented 7 years ago

I implemented it myself and fixed the issue with lab. Releasing a new version soon...