search

p-meier / hapi-api-version

An API versioning plugin for hapi.
Apache License 2.0
74 stars 26 forks source link

2.3.0: Update dependencies to new hapi scope #30

Closed drouarb closed 5 years ago

drouarb commented 5 years ago

Hey,

I updated your hapi plugin since I need it. There is a problem with the tests code coverage but I think it comes from the update of lab.

Coverage

timcosta commented 5 years ago

Hey @drouarb! Thanks for this PR - there are a few issues that would need to be fixed before it can be merged. First is the drop in coverage you mentioned. That should be bumped back up to 100%. Second, this specifies a peerdep of hapi @18.3.1, which is latest. This module is compatible with v17 and v18, which makes this peerdep of "latest" much too strict.

timcosta commented 5 years ago

Works for me. I was planning on getting to this later today if no one else had completed this PR.

On Thu, Jul 11, 2019 at 8:56 AM Frank Thelen notifications@github.com wrote:

@frankthelen commented on this pull request.

In package.json https://github.com/p-meier/hapi-api-version/pull/30#discussion_r302526752 :

@@ -23,17 +23,17 @@ "node": ">=8.0.0" }, "peerDependencies": {

  • "hapi": ">=17.x.x"
  • "@hapi/hapi": "^18.3.1"

Woudn't make it that strict in peerDependencies. What about this one:

"@hapi/hapi": ">=17.x.x"

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/p-meier/hapi-api-version/pull/30?email_source=notifications&email_token=AA54FVNSA6CNF2STOPO6I4LP64UW3A5CNFSM4HOI7DZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6EZRLQ#pullrequestreview-260675758, or mute the thread https://github.com/notifications/unsubscribe-auth/AA54FVISGPVHZAUBBR3JWTTP64UW3ANCNFSM4HOI7DZQ .

timcosta commented 5 years ago

Closing in favor of #33, as this PR hasn't had activity from its owner in some time.