p-org / PSharp

A framework for rapid development of reliable asynchronous software.
MIT License
390 stars 37 forks source link

brace matching fixes and switch to standard colors #464

Closed lovettchris closed 5 years ago

lovettchris commented 5 years ago

Fix brace matching at end of file specifically. Also switched to using standard colors so that the "light" theme looks nice.

Currently the P# language service defined custom colors with hard coded defaults that are not sensitive to the theme. The colors chosen look good on dark theme but not the light theme. These colors show up here in the Environment/Fonts and colors dialog so user can change them.

image

But is it important for users to be able to change the colors for P# tokens specifically? The downside with hard coded colors is that they look washed out when you switch to the light theme. Here the P# colors do not match C# code, they look washed out:

image

This is because our colors are not "theme sensitive". But if we switch to using standard colors then the light and dark themes work equally as well, the colors match C# and the only downside is there are no separately configurable colors for P#. This is what it looks like with this fix:

image