search

p-quic / pquic

The PQUIC implementation, a framework that enables QUIC clients and servers to dynamically exchange protocol plugins that extend the protocol on a per-connection basis
https://pquic.org
MIT License
126 stars 20 forks source link

Receiving mp_new_connection_id-frame for non-existing uniflow id #13

Closed The3ternum closed 3 years ago

The3ternum commented 3 years ago

Upon setting up a connection where my client sets the transport parameter "max_sending_uniflow_id" to 0 it still receives a mp_new_connection_id-frame where the uniflow_id is set to 1, resulting in an error because the client does not have a uniflow with id 1 for the connection.

qdeconinck commented 3 years ago

Indeed, the multipath plugin does not check the value of the transport parameter provided by its peer to reserve new connection ID frames. Going to implement a fix for this :-)

qdeconinck commented 3 years ago

This should have been fixed in the latest commits. Could you check that it is ok now?

The3ternum commented 3 years ago

Running an endpoint on the latest commit seems to indeed solve the issue. Thank you for the fix, closing this issue now.

mpiraux commented 3 years ago

The fix should now be deployed on the public test endpoint as well.