search

p-quic / pquic

The PQUIC implementation, a framework that enables QUIC clients and servers to dynamically exchange protocol plugins that extend the protocol on a per-connection basis
https://pquic.org
MIT License
126 stars 20 forks source link

fatal error: ptmalloc3/malloc-private.h: No such file or directory #6

Closed mayankmclaren closed 4 years ago

mayankmclaren commented 4 years ago

Hi, I am trying to run PQUIC but while running make command in pquic directory I am getting this error:

fatal error: ptmalloc3/malloc-private.h: No such file or directory 5 | #include "ptmalloc3/malloc-private.h" | ^~~~~~~~ Screenshot from 2020-06-12 00-55-26

I am following instructions given on https://pquic.org/ Screenshot from 2020-06-12 00-56-20

mpiraux commented 4 years ago

@francoismichel, could you update the instructions on the website and in the README to include building ptmalloc ?

mpiraux commented 4 years ago

Meanwhile, instructions for building ptmalloc are available here: https://github.com/p-quic/pquic/tree/master/picoquic/michelfralloc. Follow that and it should resolve this error.

qdeconinck commented 4 years ago

In future release, we plan to leverage the michelfralloc submodule to avoid facing these build problems.

mayankmclaren commented 4 years ago

That link solved the problem. Thank you. I wanted to ask one more question is there a plugin to make PQUIC unreliable or partially reliable...?

mpiraux commented 4 years ago

The datagram plugin implements https://tools.ietf.org/html/draft-ietf-quic-datagram-00, which adds unreliable datagrams to QUIC. I propose to keep this issue open until the instructions get clarified.

mayankmclaren commented 4 years ago

Thank you, sure I'll keep it open.

qdeconinck commented 4 years ago

Fixed by commits f802b97 and 57acaac.