gcc 4.8.5 compatibility

p-ranav / indicators

Activity Indicators for Modern C++

MIT License

3.04k stars 237 forks source link

gcc 4.8.5 compatibility #97

Closed joseluzon closed 1 year ago

joseluzon commented 3 years ago

Using gcc 4.8.5 results in a compile error:

/root/.conan/data/indicators/2.0//_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/indicators/display_width.hpp:4:18: error: missing binary operator before token "(" [build] #if __hasinclude()

It could be fixed just adding a guard like:

#if defined(__has_include)
#if __has_include(<codecvt>)
#include <codecvt>
#define INDICATORS_HAVE_CODECVT 1
#endif
#endif

aengusjiang commented 1 year ago

fix at pull 115 waiting merge the pr

p-ranav commented 1 year ago

Merged. Thanks.