search

p-ranav / structopt

Parse command line arguments by defining a struct
MIT License
457 stars 26 forks source link

Use std::string_view where appropriate #27

Closed Ahajha closed 1 month ago

Ahajha commented 1 month ago

Sort of a draft, sort of ready. There are probably more places where std::string could be replaced with std::string_view, but I got most of the obvious stuff. Also included a few string related changes. It's also possible I could do more, but some stuff could involve breaking changes.

@schaumb FYI, you might be interested.

Ahajha commented 1 month ago

@p-ranav Are you still accepting PRs for this repo?

Ahajha commented 1 month ago

@p-ranav Thanks! I might make some more PRs, some build system stuff plus a bug I found. Also I didn't update the amalgamated header, I can make a separate PR to make it easy for you if you'd like.

p-ranav commented 1 month ago

Yes, please :) Thanks!