p-ranav / tabulate

Table Maker for Modern C++
MIT License
1.93k stars 138 forks source link

Color is not working in nested tables #63

Open maximiliank opened 3 years ago

maximiliank commented 3 years ago

When I try to put a Table with a colored cell into another Table the color is not working anymore.

Here is an example:

#include "tabulate/tabulate.hpp"
#include <iostream>

int main()
{
    using namespace tabulate;

    Table inner;
    inner.add_row({"A"});
    inner[0][0].format().font_color(Color::green);
    std::cout << "Here 'A' is green:\n" << inner << std::endl;

    Table outer;
    outer.add_row({inner});
    std::cout << "Here 'A' is not green:\n" << outer << std::endl;
    return 0;
}

which gives the following output on Ubuntu:

Here 'A' is green:
+---+
| A |
+---+
Here 'A' is not green:
+-------+
| +---+ |
| | A | |
| +---+ |
+-------+
p-ranav commented 3 years ago

Yeah this is a known issue and it has to do with std::stringstream not retaining the termcolor colors.

Essentially, how nested tables are implemented are as follows:

If the inner table colors were preserved in the first step, this would work as we want. Unfortunately, this is not the case.

Nested table support was added as sort of an after-thought/bonus feature. I may have to just implement printing of nested tables with iteration (starting from the outer table and going in), which is non-ideal.

maximiliank commented 3 years ago

Thank you for your reply.

I tried to add << termcolor::colorize, see https://github.com/ikalnytskyi/termcolor/pull/20, to the inline void Printer::print_table(std::ostream &stream, TableInternal &table) function. The color works, but the right borders are messed up. Do you think it could work this way?

tqolf commented 3 years ago

ansi escape sequence should be considered in get_sequence_length to support colorful nested table. I have implemented by myself https://github.com/vxfury/tabulate. and with true color supported, too.

tqolf commented 3 years ago

ansi escape sequence should be considered in get_sequence_length to support colorful nested table. I have implemented by myself https://github.com/vxfury/tabulate. and with true color supported, too.

截屏2021-10-20 11 58 22
p-ranav commented 3 years ago

A pull request would be greatly appreciated :)

791136190 commented 1 year ago

Is there a support plan for this feature?

edisonhello commented 1 year ago

An easy bypass of this issue is to convert the table to string manually with termcolor::colorize, enable the multibyte char, and then limit the width manually.

sandmeteor commented 1 year ago

@edisonhello can you give code for this 'bypass' ? @vxfury link https://github.com/vxfury/tabulate is not available - is it a chance to get this piece of code?