search

p-rivero / DiscordAudioStream

Windows utility for streaming (with audio!) in Discord. Easily share the the audio of entire screen, or even use OBS for streaming!
GNU General Public License v3.0
180 stars 7 forks source link

Audio meter feature request #15

Closed Cloudax722 closed 1 year ago

Cloudax722 commented 1 year ago

Hi privero

I have been using the Discord audio stream for a few days now and I think that it works amazing and has made sharing things on Discord so much earlier. It has worked for every use case I have been able to throw at it.

The reason for the feature request is that during testing I always had to involve someone before I could test what people were hearing on the streamside. That's why I am requesting an audio meter feature.

The audio meter should be able to display the audio levels of what Discord audio stream is hearing. Here is a mockup of what picture it might look like

Mock-up

Here are the design files for how I conceptualized the audio levels

Design idea

I hope you are interested in adding this feature.

p-rivero commented 1 year ago

That's an excellent feature request! I'm currently a quite busy with other work, but I will try to make some time to implement this when I can.

p-rivero commented 1 year ago

I had some free time and added a basic audio meter. I went for your design 2, and I think it ended up looking great! Right now, the audio meter always pops up when clicking "Start stream". Before the final release I'll add the option to hide it if the user doesn't need it. Feel free to download the latest pre-release and let me know if it works for you!

Cloudax722 commented 1 year ago

Hi privero

I just tried out the latest pre-release and it works extremely well. I love that you decided to use the designs I provided. Having the levels a separate window is brilliant by the way. It made navigating easier and added a level of customizability that I like. Thank you so much for adding my requested feature. I really appreciate it.

While trying the new feature I thought I would stream OBS audio. I managed to get it to pick up the OBS audio by using the monitoring option like this: [image: image.png]

[image: image.png]

The problem I found with doing this is that DiscordAudioStream starts to have an audio feedback loop when I do this. Is there any way around it?

On Mon, Apr 24, 2023 at 9:11 PM privero @.***> wrote:

I had some free time and added a basic audio meter. I went for your design 2, and I think it ended up looking great! Right now, the audio meter always pops up when clicking "Start stream". Before the final release I'll add the option to hide it if the user doesn't need it. Feel free to download the latest pre-release https://github.com/p-rivero/DiscordAudioStream/releases/tag/latest and let me know if it works for you!

— Reply to this email directly, view it on GitHub https://github.com/p-rivero/DiscordAudioStream/issues/15#issuecomment-1520691234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY6ZRR4Z6ILVW4NLCCBZK4TXC3F6NANCNFSM6AAAAAAW6R3AXI . You are receiving this because you authored the thread.Message ID: @.***>

-- Kind Regards Allister Petersen

p-rivero commented 1 year ago

I cannot see the images you attached, try commenting directly on the GitHub issue, or uploading the image somewhere and adding the link.

Cloudax722 commented 1 year ago

image image

p-rivero commented 1 year ago

The feedback loop is probably happening because the output device of DiscordAudioStream is set to "Default" in Windows audio settings, and the Default is set to "VoiceMeeter Aux Input" (this is just me speculating, feel free to correct me if this is not the case). The easiest solution is to set the output of DiscordAudioStream to an unused audio device that you are not listening.

Also, if you are not using VoiceMeeter for anything else, you can just skip it and use DiscordAudioStream directly. In this case, you would need to leave the DiscordAudioStream output as Default, and set the output of the captured programs to an unused device that you then capture in DiscordAudioStream. This is explained in the section "Stream to Discord using OBS" of the docs.

p-rivero commented 1 year ago

This feature is now shipped in v1.3.0! I will now close this issue.

If you are still having trouble with the audio loop, feel free to open a new issue dedicated to discussing that.