search

p-rivero / DiscordAudioStream

Windows utility for streaming (with audio!) in Discord. Easily share the the audio of entire screen, or even use OBS for streaming!
GNU General Public License v3.0
187 stars 7 forks source link

[question] DeviceFriendlyName vs FriendlyName in AudioPlayback::RefreshDevices #17

Closed braddevans closed 1 year ago

braddevans commented 1 year ago

Hello just wondering why the use of DeviceFriendlyName over FriendlyName which would make it easier for people with multiple audio lines on the same device

FriendlyName style names

image

DeviceFriendlyName

image

p-rivero commented 1 year ago

Hi! I originally used DeviceFriendlyName to keep the names short, since otherwise the list usually gets clipped, as you can see in the screenshot. But other than that, there was no particular reason, I simply had no reason to change it.

You make a good point about the multiple audio lines on one device, thank you for the suggestion! I have switched to FriendlyName and will publish the release when I have some time to resolve other pending issues.

I think I'll remove the refresh button of the audio list, since the devices don't change that often and the user can just close and re-open the window to refresh them. This will give us more space to see the list.

p-rivero commented 1 year ago

Update: This feature is now shipped in v1.3.0