search

p-rivero / DiscordAudioStream

Windows utility for streaming (with audio!) in Discord. Easily share the the audio of entire screen, or even use OBS for streaming!
GNU General Public License v3.0
187 stars 7 forks source link

Feature request: Smaller preview sizes #23

Closed Cloudax722 closed 1 year ago

Cloudax722 commented 1 year ago

The current preview sizes are great, they work well in a 4k setup. But in smaller setups like 1080p, it gets harder to work with the preview window because it obscures a lot of what's happening on screen.

Would it be possible to have more scale sizes added to the scale drop-down menu? Maybe something like 20%, 15%, and 10%?

p-rivero commented 1 year ago

Adding that feature would be easy, but I don't really understand why that's needed.

The DiscordAudioStream window is captured by Discord and shown to the viewers, so making it too small would reduce the video quality of the stream. For instance, if I capture a 1080p screen but then set the scale to 20%, the video quality would be roughly 480p (1080*sqrt(0.2)), which is much less than the 720p allowed for free on Discord.

Discord should be able to capture windows that are hidden behind other windows or partially off-screen, so if the DiscordAudioStream window is too big you can just hide it away (without minimizing it!).

Maybe I misunderstood your question, let me know if I missed something.

p-rivero commented 1 year ago

Now that I think about it, it would probably be useful to have a Scale option that is a fixed height (like 720p) instead of a fixed percent (like 50%). This way, if the captured window changes size frequently, the stream quality is always optimal.

Cloudax722 commented 1 year ago

I think that is a better solution.

What I want is to see what's happening on my stream similar to how I would monitor things in obs. Having the window resizeable will make it easier for me to work with it.

p-rivero commented 1 year ago

I see, allowing the user to resize the window is probably the best option. I will investigate how easy this would be to implement. It would probably require some major changes, as the window size is currently adjusted dynamically and having user input would make it much messier.

p-rivero commented 1 year ago

I added your suggestions (20%, 15%, and 10% resolution) to the latest pre-release. Also, there are fixed sizes for 720p and 1080p.

I had a look at manually resizing the window, and I don't think it's feasible currently. However, with the new Scale options this shouldn't be an issue anymore.

Let me know if the new scale options are working correctly for you.

p-rivero commented 1 year ago

Closing this issue, as this feature has been implemented in v1.3.1