p-rivero / DiscordAudioStream

Windows utility for streaming (with audio!) in Discord. Easily share the the audio of entire screen, or even use OBS for streaming!
GNU General Public License v3.0
180 stars 7 forks source link

Add config's feature #37

Closed VasyaYovbak closed 8 months ago

VasyaYovbak commented 8 months ago

Hi, it would be nice to add to this program the ability to create different configurations and switch between them using hotkeys. Expected Result :

p-rivero commented 8 months ago

Thank you for the feature request, let's see if I can better understand what you mean by "config". Do you want to switch which screen/window is being captured (without stopping the stream), or is it something different?

Regarding "binding hotkeys for start/end stream", you can already start the stream with Ctrl+Enter and stop it with Esc.

VasyaYovbak commented 8 months ago

Close to what you mean. I want to be able to save different "custom areas" (eg the left side of the monitor and the right side of the monitor) and then switch between them in real time using hotkeys. I saw that you store the user configuration in the AppData folder, maybe you just need to add an option to create multiple of these configurations and switch About "binding hotkeys for start/end stream" yeap , my fault )

p-rivero commented 8 months ago

It's not as easy as just switching configuration files, but I think this could be implemented relatively easily and it's an interesting feature. The word "config" could be misleading, I think "preset" better reflects what we are trying to accomplish.

Here's a proposal of how it could work, feel free to add new ideas:

Presets: There are ~10~ 5 preset slots numbered ~0 to 9~ 1 to 5. Each slot stores the following information:

Saving a preset: Press Ctrl+Shift+1 up to Ctrl+Shift+5 to store the current capture settings in the preset 1 to 5.

Restoring a preset: Press Ctrl+1 up to Ctrl+5 to restore a previously saved preset. If the user has not started the stream yet, an info popup is shown. If the stream is running, the switch is performed silently without needing to stop the stream.

VasyaYovbak commented 8 months ago

Great idea! I'm looking forward to it!

p-rivero commented 8 months ago

I had some free time yesterday so I started implementing this feature. I think having 10 slots is unnecessary, since most people will only need 2 or 3, so for now there's only 5 presets (Ctrl+1 to Ctrl+5). I still haven't had time to update the UI, so you will have to use keyboard shortcuts. Check out the pre-release and let me know if you find any bugs.

Update: The new UI is now implemented as well

VasyaYovbak commented 8 months ago

Hi, I've been using this feature for 2 days and I'm very happy with how it works) I didn't find any major bugs. Unless 1, when we change the mode from custom to full screen (or any other but not custom) using the key combination and then turn back, a red border appears (the area that shows the screen area) In general, thank you very much for your work, now using a 32 by 9 monitor is much more pleasant

p-rivero commented 8 months ago

This issue should be fixed in the newest pre-release, see if everything now works as you would expect.

p-rivero commented 8 months ago

This feature is now released in v1.4.0