search

p-rivero / DiscordAudioStream

Windows utility for streaming (with audio!) in Discord. Easily share the the audio of entire screen, or even use OBS for streaming!
GNU General Public License v3.0
187 stars 7 forks source link

app crashes #5

Closed Teraisu closed 2 years ago

Teraisu commented 2 years ago

app crashes on the pre release after setting the app up, doing the discord mixer, and doing the input.

p-rivero commented 2 years ago

When does it crash exactly? Right after choosing an audio input in the drop-down or after clicking "Start Stream"? Is there any error message?

Teraisu commented 2 years ago

Once I click start stream and click on my browser the app would crash. Also, there's no error code.

p-rivero commented 2 years ago

Could you check which capture method is enabled in the settings? Right now I don't know what can be causing the crash. Could you record a video replicating how the crash happens? That would be really helpful.

Teraisu commented 2 years ago

its hard for me to send a video, it says that the file size is too big. the capture method used is dxgi duplication and windows 10. while having the discord audio window open, it would crash once i click to do other things, without error. the app just closes, then i have to try to open it again.

p-rivero commented 2 years ago

I see. Here are some things you could try to see if we can narrow down the source of the crash:

  1. In settings, change both capture methods to BitBlt and check if it still crashes.
  2. Click "Start stream" without selecting any audio input and check if it still crashes.
  3. If none of the previous 2 solve the crashing, try using version 1.1.0.
Teraisu commented 2 years ago

yea its still crashes while changing both of the capture methods. however, the other version works perfectly fine.

p-rivero commented 2 years ago

I added some code to output a file called stack_trace.txt next to the .exe when it crashes, could you download the latest prerelease and see if it prints anything?

Teraisu commented 2 years ago

from what ive seen the app still crashes the same way. doesnt output any file when crashing.

p-rivero commented 2 years ago

Well, since the old version works just fine, you will probably have to use it for now until I have some free time to fix this issue. I'm quite busy right now, but in 1 or 2 weeks I will have a look at this and try to find a fix.

Teraisu commented 2 years ago

It's fine take your time !

p-rivero commented 2 years ago

Sorry this took so long, I've been very busy lately. I added a new option in Settings > Debug for printing a log of the actions performed inside the program. Please read the new section at the end of the readme: Reporting a bug/crash. The log should help me find out why the app is crashing (and more importantly, why it's not printing the stack trace when it crashes). Thank you for your patience. Edit: The download link is the same prerelease link as always.

Teraisu commented 2 years ago

no problem, however, its still crashing. here's the debug log. DiscordAudioStream_log.txt

p-rivero commented 2 years ago

Ok, now at least I know where the problem is. Could you try this prerelease and send me the logs again?

Teraisu commented 2 years ago

DiscordAudioStream_log.txt

after clicking start stream and having the window up, it would freeze after clicking on other things.

p-rivero commented 2 years ago

I see... I'm sorry this is taking so much time. I have not been able to reproduce this bug in my computer, so the only way I have to find the issue are your logs. Can you download the latest prerelease and send me the logs again? It will still freeze, but the logs should be more useful now.

Teraisu commented 2 years ago

DiscordAudioStream_log.txt

Don't worry about it i know that you're trying your hardest. I think its cause im playing on a different game res so the app bugs from it. i play on 1024x768 and thats not my monitors native.. idk if thats the cause of it though.

p-rivero commented 2 years ago

Don't worry about it i know that you're trying your hardest

Thank you for understanding :)

I think its cause im playing on a different game res so the app bugs from it

That's actually a very good idea, the app does indeed seem to freeze when I open a fullscreen game. As soon as I have some free time I will submit a fix, it should be ready in a few hours.

p-rivero commented 2 years ago

Ok, this prerelease fixes the fullscreen app issues. Let's see if it also fixes this issue once and for all.

Teraisu commented 2 years ago

DiscordAudioStream_log.txt the screen turns black when playing. however, when i go back into my desktop it works again. theres still a res issue. ive tried playing on 1920 x 1080 and it works fine with aspect raitio. when changed to full screen 1024 x768 the discord audio stream turns black.

p-rivero commented 2 years ago

At this point I'm starting to think this may be an issue with DirectX. Could you tell me a game where this issue happens, so that I can download it and try to reproduce the bug?

Teraisu commented 2 years ago

Valorant

p-rivero commented 2 years ago

Well, this is a complete wild guess, but I made some changes which may (or may not) fix this issue: download link. If it still doesn't work, send me the logs and also try the following:

Which of those combinations (if any) solve the black screen issue?

Teraisu commented 2 years ago

Sorry for the wait, unfortunately, it still doesn't work. I think it's a res issue while playing instead of playing native.

p-rivero commented 2 years ago

That's unfortunate... Could you send me the debug logs and also tell me which (if any) of the following solve the issue?

Teraisu commented 2 years ago

still having issues when using these settings. however, ive tried it on counter strike and it worked perfectly fine. When on the main menu on valorant its fine. selecting training range can continue to shoot around it the screen goes black. if i was to switch to native res on val it works fine. DiscordAudioStream_log.txt

p-rivero commented 2 years ago

By looking at the log it seems that you are not using the latest version of DiscordAudioStream. You either forgot to download the new version or you are attaching the incorrect logs. Could you check again and send me the log?

If you were not using the latest version, this could explain why there was no improvement even when changing the game settings.

Teraisu commented 2 years ago

oh sorry about that , ive tried again DiscordAudioStream_log.txt

p-rivero commented 2 years ago

And does it work? Have you tried the changes I suggested?

  • Change the Screen Capture method to Windows 10.
  • Change the Screen Capture method to BitBlt
  • In Valorant, change the display mode to "Windowed Fullscreen" instead of "Fullscreen".
Teraisu commented 2 years ago

Unfortunately it doesn't work still.

p-rivero commented 2 years ago

The Windows 10 and BitBlt methods are usually very reliable, so it's not normal that neither of them work. I'm starting to think this could be a bug in the way Discord captures video, or perhaps some kind of anticheat from Valorant. In another issue you mentioned that you have 2 monitors. When you say that "the screen goes black", which of those do you mean?

  1. You have the DiscordAudioStream window in the second monitor, and you can see that the captured image is black.
  2. Other people in Discord only see a black image when they watch the stream.
Teraisu commented 2 years ago

They only fix is when I play on the native res. But when I play on the 1024x768 it stops working.this is the issue that occurs " 1. You have the DiscordAudioStream window in the second monitor, and you can see that the captured image is black and so does the viewers "

p-rivero commented 2 years ago

Ok, thank you for staying patient. I will do some testing with other games at low resolutions and I will let you know if I find anything

Teraisu commented 2 years ago

No problem, I feel like its only a val issue. Hasn't been an issue for me on counter strike.

Teraisu commented 2 years ago

Is that new update for this ?

p-rivero commented 2 years ago

No, it's only for some minor improvements that are not directly related to this issue. It's just that those changes have been accumulating in the dev branch for some time and I wanted to group them in a new release.

p-rivero commented 2 years ago

I installed Valorant on another PC with Windows 10, and it still works fine when I change the video resolution in the settings. I will probably close this issue, since it's currently unfixable and I cannot reproduce it.

Before leaving it as a lost cause, there are still a couple of things we could try:

Teraisu commented 2 years ago

Got it to work !

p-rivero commented 2 years ago

That's great! How did you fix it?

Teraisu commented 2 years ago

That's great! How did you fix it?

I had my nvidia settings set to the res that I wanted (1024x768) instead of having the res changed in game. I'm assuming that the res on the desktop was conflicting with the res in game, which caused the stream bug. When I matched the res on the nvidia control panel with the res in the game it worked.