search

p-society / coupon-aggregator-client

Client side source tree for CAS
3 stars 3 forks source link

UI changes #14

Closed ekansh0unofficial closed 2 months ago

ekansh0unofficial commented 2 months ago

Added == 1> Changing The Ui for listTile , did not delete old class for comparsion and further changes 2> Adding The ShimmerListTile for the new ListTile Modified == 1> Modified the ViewScreen class to use the new Ui elements

zakhaev26 commented 2 months ago

PR is getting big. Preferred LoC is <=300. Please fix it ASAP,or review and push to main. CC @Divyakumar21202

Divyakumar21202 commented 2 months ago

Thanks for letting me know. I'll merge it to main .

On Fri, 16 Aug, 2024, 12:06 am Soubhik Gon, @.***> wrote:

PR is getting big. Preferred LoC is <=300. Please fix it ASAP,or review and push to main. CC @Divyakumar21202 https://github.com/Divyakumar21202

— Reply to this email directly, view it on GitHub https://github.com/p-society/coupon-aggregator-client/pull/14#issuecomment-2291944197, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5USLXILKUCQX446I3ET543ZRTYMPAVCNFSM6AAAAABMR7PSGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRHE2DIMJZG4 . You are receiving this because you were mentioned.Message ID: @.***>

Divyakumar21202 commented 2 months ago

Please note that before making any PR , pls have a look that LoC is <=300 . Pls make the PR again with follow up the above conditions. @ekansh0unofficial