search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

Added Contact and Thank You pages #23

Closed geekysrm closed 6 years ago

geekysrm commented 6 years ago

Review @knrt10 .

knrt10 commented 6 years ago

Hey @geekysrm! I just wanted to give you some feedback about your work regarding PRs you make. Its not related to code but about the approach you follow.

I see that you've closed a PR and opened a new - this is pretty destructive, as it changes the history so that commits (and times when the code isn't perfect) that people have talked about are no longer visible. I know its intimidating to share code that isn't finished or perfect, but that's what open source is - generally speaking, you should never do this, it’s totally normal if you don’t understand git thst much, everyone starts from something. There are exceptions, but especially in open source everything should be visible. It's better for everyone to see how you've improved your code over time, working with us in the open.

Let me know if that makes sense or if you need clarification :heart: . Me and @palash25 are making some tutorial that might help you so before making any PR please follow it, will share in a day or two.

knrt10 commented 6 years ago

@geekysrm thank you for your contribution.

geekysrm commented 6 years ago

Ya bro @knrt10. Please make the tutorial, in great need of it.. I am kinda new to open source, so a tutorial will surely come in handy. 😀