search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

Add a carousel to the members section #25

Closed palash25 closed 5 years ago

knrt10 commented 6 years ago

will do

palash25 commented 6 years ago

@debck wanna give this a crack?

debck commented 6 years ago

sure will give a try 😄

sudonitesh commented 6 years ago

please give some idea how it should look like. like whether the pictures should be cover size or anything?

knrt10 commented 6 years ago

Carousel should be for whole cards. Cards should move not images

palash25 commented 6 years ago

Wait a minute. Lets decide who will be implementing it. I don't want duplicate PRs. @knrt10 @debck @sudonitesh

palash25 commented 6 years ago

please give some idea how it should look like. like whether the pictures should be cover size or anything?

I just want the cards to move around so that all the members get a chance to be featured on the homepage.

palash25 commented 6 years ago

There are other issues that can be split up between the two of you @debck @sudonitesh So either you two decide who will be implementing this or we are gonna have to.

This is actually my fault I should have done an assignment. @knrt10 can you install a probot that will help assign issues and automate other shit?

debck commented 6 years ago

If @sudonitesh wants to try hand with jekyll ,then he can try as i did one issue already. I will take some other issue

palash25 commented 6 years ago

Great @sudonitesh all yours

sudonitesh commented 6 years ago

I'm not able to make this responsive when i try to make the carousel with 6 members because with present styling. And any carousel with single member is not looking good with the present style. @debck please try.

palash25 commented 6 years ago

You really gonna give up that easy @sudonitesh ? If you give it another try and make it work you might end up learning something. Think about it. If you still don't wanna do it then its fine by me :+1:

sudonitesh commented 6 years ago

I made but it's not coming responsive. But still will give another try.

palash25 commented 6 years ago

Make a WIP PR so that @knrt10 can guide you further and help you make it responsive

sudonitesh commented 6 years ago

ok i will. let me try another time

palash25 commented 6 years ago

@sudonitesh any updates? As a mentioned earlier you can make a WIP (work in progress) PR even if the carousel isn't responsive so that @knrt10 can take a look at your code and guide you through it.

palash25 commented 6 years ago

And I have sent you a collaborator invite to this repo. Did you accept it?

sudonitesh commented 6 years ago

I have not got any confirmation mail. I'll make the PR today.

palash25 commented 6 years ago

@sudonitesh accept this https://github.com/p-society/p-society.github.io/invitations