search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

create swap1108.md #27

Closed swap1108 closed 6 years ago

swap1108 commented 6 years ago

Please review this

knrt10 commented 6 years ago

@swap1108 please fix the errors. And try to run locally and fix the errors then make a PR. steps to run tests are given in readme file.

palash25 commented 6 years ago

Also @swap1108 after you are done with your changes commit them into the existing commit using

git add .
git commit --amend --no-edit
swap1108 commented 6 years ago

Thanks @palash25 and @knrt10 . I will try to do so

palash25 commented 6 years ago

I think it would be better if we open a new PR for this and close this one since @swap1108 hasn't amended the commits and has made 5 unnecessary commits this will fuck up our git log. What do you think @knrt10 ?

swap1108 commented 6 years ago

Fine close it, i understand

palash25 commented 6 years ago

@swap1108 I have closed it just make a new one with a fresh branch and copy paste the whole thing and please push with a single commit.

Thanks :+1: