search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

update index.html #40

Closed nayonika1999 closed 6 years ago

nayonika1999 commented 6 years ago

'latest blog'-> 'latest post'

palash25 commented 6 years ago

@nayonika1999 I like the fact that you have made separate commits for the changes but we don't need two PRs for one issue.

I am closing the other one and just make that change in your other PR as another commit in this PR and then we can merge

1 issue can only have 1 PR but a PR can have multiple commits. Keep that in mind.

palash25 commented 6 years ago

One more thing @nayonika1999 can you provide an issue link in your commit message?

Go to your branch and do git commit --amend An editor would open in your shell just add an issue reference after your commit description Closes <full-issue-url> Then do ctrl+o then enter and then ctrl+x and your commit message would have been amended.

Then do a force push git push -f <remote-name> <branch-name> and we will be good to merge.

I am sorry I forgot to tell you this in the last review.

nayonika1999 commented 6 years ago

yup sure @palash25 .