search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

[WIP] added carousel #45

Closed sudonitesh closed 5 years ago

sudonitesh commented 6 years ago

Don't know this template engine so added the same for loop with limit 4. My previous try was to set time interval but that makes it unresponsive.

sudonitesh commented 6 years ago

@knrt10 how to lint?

palash25 commented 6 years ago

@sudonitesh try googling code linting and look for a linter

sudonitesh commented 6 years ago

@palash25 i did, but the file i edited was not pure html file. so it gives error

palash25 commented 6 years ago

Which linter did you use? Post the error log too.

sudonitesh commented 6 years ago

ok done . I had an extra closing tag.

palash25 commented 6 years ago

This will help with squashing https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history

knrt10 commented 6 years ago

@sudonitesh any updates?

sudonitesh commented 6 years ago

@knrt10 was that linting? can you please explain or some resource to see or tell me the errors?

knrt10 commented 5 years ago

@sudonitesh you working on this?

palash25 commented 5 years ago

Why was this closed ?

sudonitesh commented 5 years ago

@palash25 sorry..I made two pull request wrongly. so i closed this. but the code is same just added them in separate files.

palash25 commented 5 years ago

whats the point of making a new PR if the code is the same. Also I think you have deleted your branch so I don't think if we can reopen this again.

Lets continue from the new one but this should not happen again :wink: