Add links to Mozilla Campus Club , ACM Chapter , Papers We Love in the home page

p-society / p-society.github.io

Official site of p-society (OLD)

https://p-society.herokuapp.com/

MIT License

31 stars 26 forks source link

Add links to Mozilla Campus Club , ACM Chapter , Papers We Love in the home page #46

Open arijeetsat opened 5 years ago

arijeetsat commented 5 years ago

To mention the all the above three in the home page , and add a small description , links to twitter and official pages. Better to add it on right side of home view.

knrt10 commented 5 years ago

@arijeetsat I don't want to sound rude but please don't assign anyone yourself. If anyone else is interested they can do that. Just open the issue if anyone is not interested I will myself do that.

arijeetsat commented 5 years ago

@arijeetsat please don't assign anyone yourself. If anyone else is interested they can do that. Just open the issue if anyone is not interested I will myself do that.

I have actually assigned ,for you guys to keep a track of this issue(as it has to be completed soon), of course anyone interested should come forward and do it.

Rupeshiya commented 5 years ago

I would like to fix this issue ,Can anyone please provide me these links ??

shivank01 commented 5 years ago

For papers we love: twitter- https://twitter.com/PWLBhubaneswar , Official Repo-https://github.com/papers-we-love/bhubaneswar , facebook- https://www.facebook.com/groups/198948364106861. For Acm- cc @arijeetsat , for mozilla- cc @palash25

arijeetsat commented 5 years ago

ACM Student Chapter IIIT-Bh : https://www.facebook.com/ACMIIITBh/ ACM India : http://india.acm.org/ Logo :

knrt10 commented 5 years ago

@Rupeshiya any updates on this?

Rupeshiya commented 5 years ago

@knrt10 I am little bit confused where to add ,Should I add it below follow us section ??

knrt10 commented 5 years ago

No below GitHub and above site source code on the left-hand side of footer

Rupeshiya commented 5 years ago

@knrt10 When I am trying to execute npm run test ,getting this local storage error as given below, please help. screenshot 1

knrt10 commented 5 years ago

rebase master branch and remove _site folder and then run tests again. cc @Rupeshiya. Some changes were made in package.json file and you might have old code

knrt10 commented 5 years ago

@Rupeshiya did it work?

Rupeshiya commented 5 years ago

@knrt10 Still getting same error but no of tests reduced from 4 to 2.What should i do?

knrt10 commented 5 years ago

can you provide me a screenshot? @Rupeshiya . And did you make a new branch after fetching latest code, rebased it and then made changes to the file?

Rupeshiya commented 5 years ago

@knrt10 now after fetching latest code passed the test ,here is sceenshort,is there any improvement that I should do or should I send PR now ? screenshot 15

knrt10 commented 5 years ago

Make a PR.

Rupeshiya commented 5 years ago

fixed in PR #74