search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

Edited contents in Palash Nigam's profile #58

Closed piyushmishra12 closed 5 years ago

piyushmishra12 commented 5 years ago

@knrt10 Sorry I'm still a newbie on GitHub. I did not understand what you said. Can you please elaborate so that I can make necessary changes?

knrt10 commented 5 years ago

@itsmepiyush2 please follow these steps:- 1) git checkout master 2) git branch -D Changes 3) git remote add upstream https://github.com/p-society/p-society.github.io.git 4) git rebase upstream/master 5) git checkout -b changes 6) Copy changes for github on 2 files you made 7) git add -A 8) git commit -m "commit message you want" 9) git push origin master

knrt10 commented 5 years ago

After that make a new PR

palash25 commented 5 years ago

After that make a new PR

why do you want a new PR ? @knrt10 can't he just amend the commit ? I want @itsmepiyush2 to learn amend and force push

palash25 commented 5 years ago

Just to make things clear @knrt10 we will always amend commits don't let the juniors take the easy way out :stuck_out_tongue_winking_eye: if we train them well here and be strict with our reviews it will be easier for them to contribute to major OSS organizations.

palash25 commented 5 years ago

@knrt10 this wasn't supposed to be merged yet please read the ongoing conversations before merging stuff. Now if I revert this it shows a that I have authored the commit. How do you plan to fix this?

I had also asked @itsmepiyush2 to force push https://github.com/p-society/p-society.github.io/pull/58#discussion_r211093513 how is he supposed to do that now?

palash25 commented 5 years ago

@knrt10 I need you to fix this mess

You should be more careful @knrt10 while reviewing. You didn't even realize that @itsmepiyush2 hasn't pushed the suggested changes yet and the current state of the PR doesn't even address your own review comments.

I guess you are drunk with power :stuck_out_tongue_winking_eye: since you have had sole control over this repo since the beginning from now on we should require at least 2 approvals before merging any PRs.