Add Sibasish to contributors

p-society / p-society.github.io

Official site of p-society (OLD)

https://p-society.herokuapp.com/

MIT License

31 stars 26 forks source link

Closed sibasish14 closed 6 years ago

shivank01 commented 6 years ago

@sibasish14 the photo size is larger than recommended. Therefore the card size of yours is larger than all others.

shivank01 commented 6 years ago

@palash25 @knrt10 check this out.

palash25 commented 6 years ago

@shivank01 thanks I should have been more careful while reviewing.

We will be adding a simple regex test to avoid such mistakes in the future.

sibasish14 commented 6 years ago

So should I upload another pic with lower resolution in a new PR?

palash25 commented 6 years ago

look at others Profile.md and look at the url they have posted we want that.

make another PR

sibasish14 commented 6 years ago

I guess now I don't need to create a new PR, right? (because https://github.com/p-society/p-society.github.io/issues/64 will fix this)

palash25 commented 6 years ago

Yes also merged PR can't be fixed so stop conversing on this thread. :wink: