search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

Add a regex test for member profile link #62

Closed palash25 closed 5 years ago

palash25 commented 5 years ago

the profile.md files of all the members have a field for their profile pictures which is a specific github url. We need to add a Regex test to validate that url so that it runs on every travis build.

@p-society/2021-batch who wants it? If no one claims this issue then @debck will have to do it :stuck_out_tongue_winking_eye:

sandeep-patel11 commented 5 years ago

I would like to try

palash25 commented 5 years ago

Great I hope you have understood the issue. And please read our git guidelines before making a PR https://github.com/p-society/meta

debck commented 5 years ago

Many members have there GitHub profile pic url ..and some have other links for there pic......So most of them have to change the URL... ??

palash25 commented 5 years ago

GitHub profile pic url

thats the one we want since other pictures might have a different resolution.

debck commented 5 years ago

Then some members have to change their URL ( including me)....in order to pass the tests

palash25 commented 5 years ago

ping @knrt10 need your opinion on this

shivank01 commented 5 years ago

@palash25 Instead of regex test I would recommend checking the size and resolution of pic so that anyone can upload another pic instead of only github one.

palash25 commented 5 years ago

I was talking about writing one simple unit test. I have no idea what you are talking about @shivank01

checking the size and resolution of pic

how do we do this on a static site?

pic instead of only github one.

github avatars are automatically updated that's why we use them.

Hmmn I got an idea maybe we can use Gravatar. @knrt10 can we do that? I hope everyone has a gravatar.

palash25 commented 5 years ago

@suicide11 have you started working on this? I was thinking about blocking this until we reach a consensus on this.

shivank01 commented 5 years ago

@palash25 I don't have much idea about web dev. I am saying if it is possible then we should do that.

palash25 commented 5 years ago

I was saying if it is possible then we should do that.

we dont have any backend its a static site so we can't test the images since we are not uploading and storing images to our site but are fetching them from a third party hosting service. Am I right @knrt10 ?

sibasish14 commented 5 years ago

@palash25 Let's just make this standardised- all members need to upload their GitHub profile pics. So no issues with resolution/size or no need of any tests. What say?

palash25 commented 5 years ago

That was the initial thought. Lets see what others have to say about that @p-society/2020-batch @p-society/2021-batch

Opinions here :point_down:

knrt10 commented 5 years ago

Am I right @knrt10 ?

Yes @palash25 .

shivank01 commented 5 years ago

@sibasish14 Someone can miss/ignore the template. There should be a test which can check this.

knrt10 commented 5 years ago

Let's just make this standardised- all members need to upload their GitHub profile pics.

Please read picUrl before saying anything @sibasish14 😉

debck commented 5 years ago

Only 3-4 members have URL other than github profile. We can change those and then we can write the test. ( I think)

palash25 commented 5 years ago

Blocked by #64

I agree with @debck

palash25 commented 5 years ago

@knrt10 stop making non-sensical labels please.

palash25 commented 5 years ago

@suicide11 you can get started on this

sandeep-patel11 commented 5 years ago

ok

palash25 commented 5 years ago

@suicide11 before you start on the PR do you have a clear understanding of the issue and know what changes need to be made?

sandeep-patel11 commented 5 years ago

A test is to be made which will check the picurl (it must be the GitHub profile pic url)

palash25 commented 5 years ago

A test is to be made

A test is to be made written.

What I meant was you know how to write tests right?