search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

changed profile URL #65

Closed pranayag15 closed 5 years ago

pranayag15 commented 5 years ago

Fixes #64

pranayag15 commented 5 years ago

@palash25 please review.

palash25 commented 5 years ago

@pranayag15 please amend your commits so that we can merge this soon. This is blocking another issue.

pranayag15 commented 5 years ago

@palash25 I guess I have to reinstall the packages to their older version, I'll definitely do it today.

palash25 commented 5 years ago

I guess I have to reinstall the packages to their older version, I'll definitely do it today.

No @pranayag15 just change the version to the way they were before and delete the files that were not supposed to be there. Then amend and force push and let the tests run on the CI. If it passes then we will merge.

No need to reinstall packages, broken toolchains can take a little time to fix and we need to merge this.

pranayag15 commented 5 years ago

@knrt10 have changed accordingly. plz review

palash25 commented 5 years ago

Nice work @pranayag15 :smile: