search

p-society / p-society.github.io

Official site of p-society (OLD)
https://p-society.herokuapp.com/
MIT License
31 stars 26 forks source link

added nitesh to contributors #70

Closed sudonitesh closed 5 years ago

palash25 commented 5 years ago

@itsmepiyush2 check for grammatical errors

and try to review all the other upcoming contributor PRs

knrt10 commented 5 years ago

@sudonitesh please remember to make one commit only. Didn't you read meta. Please squash your commits

sudonitesh commented 5 years ago

@knrt10 I've squashed the commits locally, Now what to do?

nitesh@Nitesh-PC MINGW64 ~/Desktop/p-society.github.io (profile) $ git rebase -i profile Successfully rebased and updated refs/heads/profile. nitesh@Nitesh-PC MINGW64 ~/Desktop/p-society.github.io (profile) $ git log --oneline bb0b431 (HEAD -> profile) add nitesh to contributors after update 6037255 (origin/master, origin/HEAD) added social media icons to contact page 27c2edd added regex test .... nitesh@Nitesh-PC MINGW64 ~/Desktop/p-society.github.io (profile) $ git log --author=sudonitesh commit bb0b431756ce2f093b22444dacf994fd03436a08 (HEAD -> profile) Author: sudonitesh nktosni@gmail.com Date: Mon Aug 27 22:58:39 2018 +0530

add nitesh to contributors after update

added nitesh to contributors

updated volunteer_experience
sudonitesh commented 5 years ago

I think its done. Please check

sibasish14 commented 5 years ago

Then remove the link. Why do you want to redirect someone to Twitter when you don't have one?😉

palash25 commented 5 years ago

@sudonitesh good work you know how to squash now.

But why do you repeat the same shortlog twice in your commit message. Please read how to make good commit message the link is in the Meta README

sudonitesh commented 5 years ago

@palash25 ya sure i'll . do i need to make any change in this pr?

palash25 commented 5 years ago

Just told you remove the second occurence of the shortlog and push, then I will merge

Also shibasis gave you a review and you haven't addressed it.

sudonitesh commented 5 years ago

@palash25 do I need to revert the 2nd commit or change the commit message??

palash25 commented 5 years ago

Which second commit? You only have one

palash25 commented 5 years ago

Change this message 

added nitesh to contributors
added nitesh to contributors

updated volunteer_experience

to this

added nitesh to contributors

updated volunteer_experience

And also remove the twitter link if you don't have a twitter

sudonitesh commented 5 years ago

@palash25 please review