search

p-society / typeracer-cli

Learn how to touch type from the comfort of your terminal and challenge your friends for a match :balloon: :smile:.
MIT License
246 stars 24 forks source link

para.json: Remove all lengthy paragraphs #27

Closed IamRaviTejaG-zz closed 6 years ago

IamRaviTejaG-zz commented 6 years ago

Paragraphs with ID 01-20 (excluding 11 & 14) need to be removed from para.json for they are very long.

PS: Those were my initial contributions, hearty apologies for that.

palash25 commented 6 years ago

They are not very long and even if they are I don't think that you should delete them the online typeracer throws you some really long paras so why should we exclude them from ours?

IamRaviTejaG-zz commented 6 years ago

@palash25 Our tool contains small paragraphs. That's why I suggested removing the really longer ones.

palash25 commented 6 years ago

But the original game has both so why not keep both since we want to provide the same experience on the shell. cc @knrt10

IamRaviTejaG-zz commented 6 years ago

I'm cool with that too. 😄

knrt10 commented 6 years ago

@IamRaviTejaG paragraph given to user is never small cause if length of paragraph is less than 100 letters it combines with latter paragraph to make it big. So no worries in removing paras 1-20. Hope you cool with that? For more info refer to this https://github.com/p-society/typeracer-cli/blob/master/online/server.js#L36 If cool then please close this issue.

IamRaviTejaG-zz commented 6 years ago

@knrt10 Yeah, I'm definitely cool with that. 😃