p / redis-dump-load

Dump redis databases, load data into redis - in Python

BSD 2-Clause "Simplified" License

175 stars 76 forks source link

Use unicode for io.StringIO, ijson should be optional #29

Closed hyunchel closed 8 years ago

hyunchel commented 9 years ago

[x] Unit tests were failing when StringIO is imported from io module - which requires non-string.
[x] Unit tests do not reflect the fact that ijson module is optional. Few test cases assumes that a user has ijson module installed.

p commented 9 years ago

Thanks for the patch!

Is it possible to mark the tests skipped when ijson is not installed? I think it would be good to know that some of the tests did not in fact meaningfully execute.

hyunchel commented 9 years ago

Hello,

Sorry about the delayed response. Would please explain what you mean by "mark the test skipped"? Thanks.

p commented 9 years ago

No worries, I will take care of it.

p commented 8 years ago

33 addresses ijson requirement in the test suite. Unicode cast is not necessary because the test suite imports StringIO from StringIO on Python 2 - not io - and that StringIO works with strings.