p00582564 / Group-Proj-1

0 stars 2 forks source link

GroupProj Code revisions #17

Open cplace2019 opened 5 years ago

cplace2019 commented 5 years ago

I revised our code per our recent group meeting discussion. See our canvas Group Project Discussion stream for more information. Please review our canvas and the revision made to the code and the master branch. I created to backup branches: one before changes and one after my changes. Also, I created a group project board.

cplace2019 commented 5 years ago

Ok, I'm good with what group members go with. I also was not sure about what comments to add. The final version does not have much comments. If you want comments, let me know which comments to add java doc format or something else? Also in the final code version the access modifier are not specified as public on the Box class, Box class constructors and methods. The suggestion in chapter 9 is to have a public front end with private instance variable (data members) which encapsulates the data and public methods.

dcmdorazio commented 5 years ago

Add comments if you would like. But do not delete anything or add anothing else. Would have been nice to have you in our group meeting today!

cplace2019 commented 5 years ago

The addition of comments or any other features are not based on my like. Please review the group project assignment slides.

-Carmen

cplace2019 commented 5 years ago

Add comments to the box class. May still need adjustment to align properly since mixture of tab and spaces. The editor kept resetting formats. I also attached a text file with the comment I added using the Github code editor. BoxClassComments.txt