search

p00f / clangd_extensions.nvim

Clangd's off-spec features for neovim's LSP client. Use https://sr.ht/~p00f/clangd_extensions.nvim instead
MIT License
448 stars 16 forks source link

add inline extmark support after neovim/neovim#20130 merged #34

Closed TwIStOy closed 1 year ago

p00f commented 1 year ago

Thanks for the PR! Please -

1) Don't make the function to convert old to inline configurable, for inline branch early 2) Squash

p00f commented 1 year ago

Should we just wait for this to be added to neovim instead? Inlay hints are part of the spec

TwIStOy commented 1 year ago

Updated!

Should we just wait for this to be added to neovim instead? Inlay hints are part of the spec

The inline virt text feature has been merged into neovim's master. I think we can use this directly?

p00f commented 1 year ago

The inline virt text feature has been merged into neovim's master. I think we can use this directly?

I was thinking of waiting for neovim to add inlay hints in their lsp implementation - it will happen eventually

TwIStOy commented 1 year ago

This issue neovim/neovim#18086?

p00f commented 1 year ago

Yes, see this comment on the issue - https://github.com/neovim/neovim/issues/18086#issuecomment-1095937211

p00f commented 1 year ago

I'll add something rudimentary for now

p00f commented 1 year ago

Sorry, I can't merge this as I had something simpler in mind - which I pushed, try it out